Add support for column identities #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplunkett-stripe
force-pushed
the
bplunkett/add-support-for-column-identities
branch
4 times, most recently
from
55eb067
to
0d80311
Compare
bplunkett-stripe
force-pushed
the
bplunkett/add-support-for-column-identities
branch
from
0d80311
to
6ca546f
Compare
alexaub-stripe
approved these changes
Sep 3, 2024
| var identity *ColumnIdentity | ||
| if len(column.IdentityType) > 0 { | ||
| identity = &ColumnIdentity{ | ||
| Type: ColumnIdentityType(column.IdentityType), |
There was a problem hiding this comment.
Should there be an error check here in case an unexpected type is returned?
There was a problem hiding this comment.
No! This is very intentional. This enables us to diff schemas without erroring out if the column identity doesn 't change. You could imagine Postgres adds a new column identity. If we errored here, our tooling would totally break even if the column doesn't change. Instead, we should aim to error out within the SQL generator, i.e., only if what we don't know about changes
bplunkett-stripe
deleted the
bplunkett/add-support-for-column-identities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for column identities. This is different from generated columns.
Motivation
Fixes #163
Testing
Passes CI